Improve slightly mapping documentation #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes to address, very partially, some concerns raised in #2371.
I think we also really need to add a
ByCodechapter, probably after theInheritance Mapping, to help people get started with ByCode. But as I am not using it much, I do not not consider I have enough knowledge about it to add such a chapter. (I may attempt something from my "NHibernate Cookbook", but I do not have access to it currently.)So this PR is just a first step to slightly improve the mapping documentation. If someone feels like adding that missing
ByCodechapter, feel free to do it here. That would be great to be able to add some link where the documentation mentionsByCodeto some real consistent documentation of it.