Fix querying with delayed entity insert #2416
Conversation
fredericDelaporte
changed the title
| Log.Debug("binding 0 to parameter: {0}", index); | ||
| } | ||
|
|
||
| st.Parameters[index].Value = 0; |
There was a problem hiding this comment.
This assumes the identifier is compatible with an int, and this assumes 0 is not a valid value for it. This will be wrong in many cases.
There was a problem hiding this comment.
DelayedPostInsertIdentifier exists only for auto-increment fields, so I believe that the value 0 in this case is correct
There was a problem hiding this comment.
I compared this behavior with entity framework core 3 comparison by reference for an entity that is not yet stored in the table returns exactly parameter 0 in all cases
There was a problem hiding this comment.
What if entity.Id is not 0 for transient entity and for instance it's -1?
DelayedPostInsertIdentifier exists only for auto-increment fields, so I believe that the value 0 in this case is correct
Not true for the following SQL Server table:
CREATE TABLE Entity
(
Id int IDENTITY(0,1), -- start from 0
Name varchar (20)
); 
|
With changes from #3043 now tests fail. |
Fix #2414