Skip to content

Fix KeyNotFoundException in StatefulPersistenceContext.RemoveEntity on Evict #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2020
Merged

Fix KeyNotFoundException in StatefulPersistenceContext.RemoveEntity on Evict #2389

merged 3 commits into from
May 20, 2020

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented May 18, 2020 •
edited by bahusoid
Loading

Fixes #1310
Initially the test was committed with a modification which made the bug not reproducible.

from @bahusoid in https://github.com/nhibernate/nhibernate-core/pull/2381/files#r425997839:

Java version doesn't throw here (HashMap.remove is used which returns null instead). Maybe we shouldn't either?

@hazzik hazzik merged commit 20a61d1 into nhibernate:master May 20, 2020
@hazzik hazzik deleted the NH-1845 branch May 20, 2020 22:24
@hazzik hazzik added this to the 5.3 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahusoid bahusoid bahusoid approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

NH-3478 - StatefulPersistenceContext.RemoveEntity KeyNotFoundException on Evict
2 participants
@hazzik @bahusoid