Support for criteria aliases in SqlProjection and SQLCriterion #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
force-pushed
the
criteriaAliasesInSql
branch
from
d923119 to
73f0c6c
Compare
Yes, this is supported. For the actual SQL it will generate unique aliases. |
hazzik
commented
May 17, 2020
| internal IDictionary<string, string> GetCriteriaSQLAliasMap() | ||
| { | ||
| var result = outerQueryTranslator != null | ||
| ? new Dictionary<string, string>(outerQueryTranslator.GetCriteriaSQLAliasMap()) |
There was a problem hiding this comment.
Creating a new dictionary because outerQueryTranslator.GetCriteriaSQLAliasMap() could be an EmptyDictionary which is read-only.
hazzik
commented
May 17, 2020
Encapsulate logic of rendering SQL aliases into CriteriaQueryTranslator
fredericDelaporte
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #896
This is an alternative approach to #2358. Here we replace all registered aliases without need of explicitly registering them.