Refactor debug logging in AbstractBatcher #2382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
May 16, 2020
| @@ -93,11 +93,7 @@ private DbCommand Generate(CommandType type, SqlString sqlString, SqlType[] para | |||
| } | |||
|
|
|||
| var cmd = _factory.ConnectionProvider.Driver.GenerateCommand(type, sql, parameterTypes); | |||
| LogOpenPreparedCommand(); | |||
| if (Log.IsDebugEnabled()) | |||
There was a problem hiding this comment.
Moved to LogOpenPreparedCommand
| @@ -232,7 +228,7 @@ public int ExecuteNonQuery(DbCommand cmd) | |||
| } | |||
| finally | |||
| { | |||
| if (Log.IsDebugEnabled() && duration != null) | |||
There was a problem hiding this comment.
duration is created only under Debug logging. I see no point in additional code cluttering with Log.IsDebugEnabled()
| } | ||
| catch (Exception e) | ||
| { | ||
| e.Data["actual-sql-query"] = cmd.CommandText; | ||
| Log.Error(e, "Could not execute query: {0}", cmd.CommandText); | ||
| throw; | ||
| } | ||
| finally |
There was a problem hiding this comment.
Useless finally block (as in case exception reader is null). Moved logic to LogOpenReader
hazzik
approved these changes
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimize clutter of
Log.IsDebugEnabledcalls and get rid of typing logic inGetReaderStopwatch