Skip to content

Proper query plan caching for DML LINQ queries #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2020
Merged

Proper query plan caching for DML LINQ queries #2299

merged 4 commits into from
Jan 12, 2020

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Jan 2, 2020 •
edited
Loading

Properly fixes #2222 by including modified property names in to query key (see #2300 (comment) for details)

@bahusoid bahusoid changed the title Revert "Cache query plan for DML LINQ queries (#2229)" WIP Revert "Cache query plan for DML LINQ queries (#2229)" Jan 3, 2020
@bahusoid bahusoid changed the title WIP Revert "Cache query plan for DML LINQ queries (#2229)" Revert "Cache query plan for DML LINQ queries (#2229)" Jan 3, 2020
@fredericDelaporte

This comment has been minimized.

Sign in to view
@bahusoid bahusoid changed the title Revert "Cache query plan for DML LINQ queries (#2229)" Proper query plan caching for DML LINQ queries Jan 5, 2020
@bahusoid bahusoid mentioned this pull request Jan 6, 2020
Merged
@bahusoid bahusoid mentioned this pull request Jan 10, 2020
Closed
@fredericDelaporte fredericDelaporte added this to the 5.3 milestone Jan 12, 2020
@fredericDelaporte
Copy link
Member

We would have better to wait for #2300 to be merged, in order to check everything is ok once combined together in master.

fredericDelaporte
fredericDelaporte approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing my mind, we should merge it first, since merging 5.2.7 to master without this fix would cause a test from 5.2.7 to fail.

@fredericDelaporte fredericDelaporte merged commit 440a64f into nhibernate:master Jan 12, 2020
@fredericDelaporte
Copy link
Member

Sorry, I have missed cleaning the commit details auto-generated by the squash.

fredericDelaporte pushed a commit that referenced this pull request Jan 12, 2020
@bahusoid @fredericDelaporte
Proper query plan caching for DML LINQ queries (#2299)
df6cbbe
@fredericDelaporte
Copy link
Member

fredericDelaporte commented Jan 12, 2020 •
edited
Loading

The resulting commit message details was too misleading (speaking of reverting a thing while no more reverting it: the code was reverted, but no more the feature change). Since the merge was recent and very few people were likely to have already got it, I have disabled the branch protection temporarily and forced pushed a reword.

@bahusoid
Copy link
Member Author

I have disabled the branch protection temporarily and forced pushed a reword.

This seems to have some side effect - all PRs on master are recently updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
c: Linq Provider p: Major r: Fixed t: Bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

NHibernate query plan for Linq Dml is not cached
3 participants
@bahusoid @fredericDelaporte @hazzik