Optimize filter applying logic #2295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
force-pushed
the
optimizeFilter
branch
from
2cfc711 to
23db149
Compare
|
CodeFactor seems to have a bug on this one. |
This comment has been minimized.
This comment has been minimized.
fredericDelaporte
approved these changes
Dec 26, 2019
| upTo = upTo >= 0 ? upTo : condition.Length; | ||
| string property = condition.Substring(startOfProperty, upTo - startOfProperty); | ||
|
|
||
| string fullColumn = propMap.ContainsKey(property) ? propMap[property] : string.Format("{0}.{1}", defaultAlias, property); | ||
| if (!propMap.TryGetValue(property, out var fullColumn)) | ||
| fullColumn = string.IsNullOrEmpty(defaultAlias) |
There was a problem hiding this comment.
Robustness improvement by the way, in case some caller may omit the alias some days? Or an actual bug fix?
There was a problem hiding this comment.
It's logic from GetColumnsToTableAliasMap
But now this part is not executed for entities without sub-classes - so I added it here just in case (and for consistency)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid property map preparation logic (
GetColumnsToTableAliasMap) if filters are disabled or there are no subclasses.And few other related refactorings