Make persistent collection classes implement the IReadOnly* interfaces

[marcelltoth]

Issue

Currently the PersistentGenericBag/List/etc. classes that NHibernate uses only implement the IList<T> or ICollection<T> interface, but not the readonly IReadOnlyList<T> / IReadOnlyCollection<T> interfaces. Unfortunately the read/write interfaces do not inherit the readonly ones. This in turn makes using such properties in my model classes illegal.

Example code:

public virtual IReadOnlyCollection<ShippingAddress> ShippingAddresses { get; protected set; }

This throws at runtime:

System.InvalidCastException: Unable to cast object of type 'NHibernate.Collection.Generic.PersistentGenericBag1[MyProject.Domain.Entities.BillingAddress]' to type 'System.Collections.Generic.IReadOnlyCollection1[MyProject.Domain.Entities.BillingAddress]'

Solution

I made sure all of our custom persistent collection classes implement the IReadOnly* counterpart as well.

At most places I only had to add the the interface, all methods / properties were already implemented by the implementation for the mutable interface. Where there were missing properties I implemented them using an explicit interface implementation so no change in the collection's public interface has been made other than the added interface implementation.

Remark

This is my first contribution to this repo. I tried to follow all the guidelines and existing coding style, but if there is anything I need to change, I welcome all feedback.

[marcelltoth]

Thank you Alexander, I never thought that collections themselves have async counterparts.