Allow configuring auto-join transaction globally #2214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Sep 15, 2019
hazzik
previously approved these changes
Sep 15, 2019
| { | ||
| Assert.That( | ||
| s.GetSessionImplementation().TransactionContext, | ||
| _autoJoinTransaction != false ? Is.Not.Null : Is.Null); |
There was a problem hiding this comment.
Granted, I should care more about avoiding negating.
Remove undue negation
hazzik
approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For application willing to enlist in current system transaction only explicitly, it would be better to be able to configure the auto-join transaction option globally rather than at each session opening.
This PR add the option as a configuration option.
Disabling auto-join may improve performance for applications which are not using transaction scopes, or which are using them seldom and takes care of re-enabling auto-join or joining explicitly in those cases.