Optimize usages of SqlString.Append #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Jun 3, 2019
hazzik
reviewed
Jun 3, 2019
hazzik
reviewed
Jun 3, 2019
ggeurts
suggested changes
Jun 12, 2019
| return new SqlString(this, text); | ||
| } | ||
|
|
||
| public SqlString Append(params object[] parts) |
There was a problem hiding this comment.
I would consider introducing a new private SqlString(SqlString other, params object[] parts) constructor which can optimise the parts copying and append operations.
There was a problem hiding this comment.
Actually I've considered such ctor. But looking at existing ctors SqlString(SqlString x) and SqlString(params object[] parts) - I didn't find a way to merge them nicely. So IMHO it's not worth it. But if you've come up with implementation - feel free to add it.
hazzik
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each
SqlString.Appendcall leads to newSqlStringcreation. And calledSqlStringctor doesn't look lightweight to me. So let's minimize subsequent Append calls.