Fix properties mapped inside a <properties> group are empty when retrieving object #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Apr 29, 2019
| //useParent = parent != null && base.ReturnedClass.IsInstanceOfType(parent); | ||
| var useParent = | ||
| parent != null && | ||
| //TODO: Yuck! This is not quite good enough, it's a quick |
There was a problem hiding this comment.
hazzik
reviewed
Apr 29, 2019
| @@ -19,9 +19,12 @@ public override bool IsEmbedded | |||
|
|
|||
| public override object Instantiate(object parent, ISessionImplementor session) | |||
| { | |||
| bool useParent= false; | |||
| // NH Different implementation : since we are not sure about why H3.2 use the "parent" | |||
There was a problem hiding this comment.
So, now we're sure why this code was written like this...
This comment has been minimized.
This comment has been minimized.
hazzik
changed the title
hazzik
previously approved these changes
Apr 29, 2019
hazzik
approved these changes
Apr 29, 2019
hazzik
changed the title
|
Thanks @lillo42 |
|
I just spent a day debugging this issue on 4.0.4.GA only to find that this bug was reported over 8 years ago and was the result of changes made to NHibernate while porting code from Hibernate. Bug fixes like these ought to be back-ported/committed to earlier versions when possible, especially when the H3.2 code on which this fix is based was written 12 years ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006