Allow columns index be shared between base and subclass properties #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Apr 3, 2019
bahusoid
changed the title
…se for now true only for PostgreSQL) Support 2+ levels of inheritance for index
…reed that it's useful)
bahusoid
commented
Apr 4, 2019
| @@ -68,7 +68,8 @@ public static string BuildSqlDropIndexString(Dialect.Dialect dialect, Table tabl | |||
| /// </returns> | |||
| public string SqlCreateString(Dialect.Dialect dialect, IMapping p, string defaultCatalog, string defaultSchema) | |||
| { | |||
| return BuildSqlCreateIndexString(dialect, Name, Table, ColumnIterator, false, defaultCatalog, defaultSchema); | |||
| var indexName = IsInherited ? Table.Name + Name : Name; | |||
There was a problem hiding this comment.
Possible improvement: avoid changing index name for dialects where same index name is allowed for different tables.
According to my tests dialects that require unique index name in database:
Firebird
Oracle
SQLite
PostgreSQL
Support same index name:
SQL Server
SQL Server CE
MySql
SAP SQL Anywhere
bahusoid
changed the title
|
Can i do something here to close this PR ? |
hazzik
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2099