Fix determination of interface proxies #2070
Conversation
Change invocation of IProxyFactory.PostInstantiate to pass correct base class depending on the set interface proxy
This comment has been minimized.
This comment has been minimized.
src/NHibernate.Test/NHSpecificTest/GH2067/BaseClassAndDerivedInterfaceProxiesFixture.cs
Outdated
Show resolved
Hide resolved
hazzik
changed the title
hazzik
changed the title
|
I think tests for this PR better to place in StaticProxyTest folder/subfolder. |
|
I'm going to drop @bahusoid's tests as I believe the existing test cases do cover the required cases. |
| public void PostInstantiate(string entityName, System.Type persistentClass, ISet<System.Type> interfaces, | ||
| MethodInfo getIdentifierMethod, MethodInfo setIdentifierMethod, | ||
| IAbstractComponentType componentIdType) | ||
| { | ||
| //6.0 TODO: throw NotSupportedException |
There was a problem hiding this comment.
Strange TODO inside obsolete method. Shouldn't we simply drop this method in 6.0? And when obsoleting something we also tend to add //Since 5.3 comment
There was a problem hiding this comment.
It’s not strange. This method would stay on the class (with additional argument) because of the interface, but shall not be supported.
Yeah, I’ve forgot about “since 5.3”
There was a problem hiding this comment.
That's not so obvious that new override is meant. But why don't add override now?
|
Regarding dropping my tests. I'm fine wit it - I've added them with the wrong idea for "interface proxy" work. So they are at least excessive. But I still think that tests should be moved to StaticProxyTest |
The logic determining if we have an interface proxy or not moved to the tuplizer.
Fixes #2067