-
Notifications
You must be signed in to change notification settings - Fork 934
Tests for proxy interface handling #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I wrote my tests a while ago - see no point dropping them now. Various scenarios for interface handling in one place. Also your tests seem to check some internal specifics of generated proxy. And my tests make no assumptions what should cause proxy initialization - they just test actual initialization. So they more abstract from actual implementation. Regarding #2271. |
Checked locally that there is no changes in async code. |
Related to #2052 and test case for #2271
Added tests to clarify expected behavior.
In 5.2 both implicit and explicit interfaces are not leading to proxy initialization on interface
Id
access.Update: After #2264 implicit interfaces are not leading to proxy initialization on
Id
access. And explicit interfaces lead to proxy initialization. Tests are adjusted according to this behavior.