Skip to content

Tests for proxy interface handling #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2020
Merged

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Mar 18, 2019

Related to #2052 and test case for #2271

Added tests to clarify expected behavior.
In 5.2 both implicit and explicit interfaces are not leading to proxy initialization on interface Id access.

Update: After #2264 implicit interfaces are not leading to proxy initialization on Id access. And explicit interfaces lead to proxy initialization. Tests are adjusted according to this behavior.

@hazzik

This comment has been minimized.

@bahusoid

This comment has been minimized.

@bahusoid
Copy link
Member Author

bahusoid commented Nov 12, 2019

I've updated tests according to changes made in #2264. Also added test case for #2271

@fredericDelaporte

This comment has been minimized.

@bahusoid

This comment has been minimized.

@fredericDelaporte

This comment has been minimized.

@bahusoid

This comment has been minimized.

@fredericDelaporte

This comment has been minimized.

@bahusoid

This comment has been minimized.

@fredericDelaporte

This comment has been minimized.

@bahusoid
Copy link
Member Author

bahusoid commented Nov 12, 2019

It does test that an explicitly implemented member is not "short-circuit" to its implicitly implemented "counter-part".

I wrote my tests a while ago - see no point dropping them now. Various scenarios for interface handling in one place. Also your tests seem to check some internal specifics of generated proxy. And my tests make no assumptions what should cause proxy initialization - they just test actual initialization. So they more abstract from actual implementation.

Regarding #2271. Maybe it's just invalid test case and issue - will double check tomorrow. Double checked - it's valid issue.

@hazzik hazzik added the c: Tests label May 2, 2020
@hazzik hazzik merged commit 62ee459 into nhibernate:master May 2, 2020
@hazzik hazzik added this to the 5.3 milestone May 2, 2020
@hazzik hazzik added the r: Fixed label May 2, 2020
@hazzik
Copy link
Member

hazzik commented May 2, 2020

Checked locally that there is no changes in async code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants