-
Notifications
You must be signed in to change notification settings - Fork 934
Fix for NH-2285 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for NH-2285 #200
Conversation
Hi @Reverseblade, it seems that ProcessLock.cs file is missing |
Hi @hazzik |
Hello any updates on this , will you merge please ? |
Any updates ? |
Can the merge (ac465e1) be removed? |
Why removal of that branch is necessary ? |
Just to make cleaner history |
Ok, now I see where is the problem. Can you please make the pull request from a topic branch, not from master? Thanks |
There seems to be some issues with indenting also (NH uses tabs for indenting). Please try to use the same indenting system as surrounding code (some files are already messed up in NH, don't try to fix them in the same branch). Given the merge commit, we cannot accept the pull request as is, so I will close it and mark the associated issue for 4.1.0. We can clean the code from this PR later, but a new clean PR will be helpful. |
I fixed https://nhibernate.jira.com/browse/NH-2285 and added some tests