Skip to content

Fix for NH-2285 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix for NH-2285 #200

wants to merge 4 commits into from

Conversation

OnurGumus
Copy link
Contributor

I fixed https://nhibernate.jira.com/browse/NH-2285 and added some tests

@hazzik
Copy link
Member

hazzik commented Apr 16, 2013

Hi @Reverseblade, it seems that ProcessLock.cs file is missing

@OnurGumus
Copy link
Contributor Author

Hi @hazzik
Apologies. This is due to my unfamiliarity with the Github windows tool. I added the files please check and merge

@OnurGumus
Copy link
Contributor Author

Hello any updates on this , will you merge please ?

@OnurGumus
Copy link
Contributor Author

Any updates ?

@hazzik
Copy link
Member

hazzik commented Aug 14, 2014

Can the merge (ac465e1) be removed?

@OnurGumus
Copy link
Contributor Author

Why removal of that branch is necessary ?

@hazzik
Copy link
Member

hazzik commented Aug 14, 2014

Just to make cleaner history

@hazzik
Copy link
Member

hazzik commented Aug 14, 2014

Ok, now I see where is the problem. Can you please make the pull request from a topic branch, not from master? Thanks

@oskarb
Copy link
Member

oskarb commented Aug 17, 2014

There seems to be some issues with indenting also (NH uses tabs for indenting). Please try to use the same indenting system as surrounding code (some files are already messed up in NH, don't try to fix them in the same branch).

Given the merge commit, we cannot accept the pull request as is, so I will close it and mark the associated issue for 4.1.0. We can clean the code from this PR later, but a new clean PR will be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants