NOT READY FOR PULL - You'll want to review the change set and integrate the way you see fit. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call to object constructor instead of base type constructor. This was causing verification exception with non-full trust policy. Added IEntityInjector as a provider to support non-default constructor entities for DI scenarios. NH still makes the Activator.CreateInstance call, but uses the constructor parms provided by the IEntityInjector implementation.
|
Please submit an issue linking to this pull request. |
|
Hi Patrick, where is best place to submit an issue? https://nhibernate.jira.com ?? |
|
Yes, rippo, on the JIRA bug tracker please |
|
Added issue at https://nhibernate.jira.com/browse/NH-2857 |
|
Since this request is not intended to be integrated, I'm going to close it. Would be good for discussion to continue in the JIRA issue. |
hazzik
added a commit
that referenced
this pull request
Aug 5, 2016
hazzik
referenced
this pull request
in ngbrown-forks/nhibernate-core
Mar 17, 2017
# This is the 1st commit message: NH-3807 - Took care of most of the GetTypeInfo() needs. Added TypeReflectionExtensions for CoreClr use. # The commit message #2 will be skipped: # fixup! NH-3807 - Took care of most of the GetTypeInfo() needs. Added TypeReflectionExtensions for CoreClr use.
This was referenced Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NH 3.2 has a bug in the default proxy factory (not sure if it's been reported). The generated proxy assembly does not pass peverify because the proxy type constructor calls object::ctor instead of the base type (entity) constructor. This means that lazy loads are limited to full-trust policy.
I fixed the proxy factory to emit call the "real" base type constructor, but this would have the side-effect of preventing constructor DI in entities. Then I added a new provider and contract (DefaultEntityInjector and IEntityInjector) so that DI is supported out-of-box by providing an implementation. The implementation simply needs to provide the constructor arguments for NH's call to Activator.CreateInstance.
I added a test project that demonstrates default constructor, interface based proxy, and non-default constructor cats. Also, peverify reports zero errors on the dynamic assembly. This has also been tested in a pseudo-medium trust environment. The required reflection permissions above default medium are emit & protected member access.
Please take a look when you have time (randy.w.lee@gmail.com or @ranzlee)
Thanks much!
P.S. I only modified the lightweight bytecode provider logic. Haven't even looked at code dom...