Skip to content

Fix System.InvalidCastException when merge collection with LazyProperty #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2019
Merged

Fix System.InvalidCastException when merge collection with LazyProperty #1992

merged 5 commits into from
Jan 24, 2019

Conversation

offan
Copy link
Contributor

@offan offan commented Jan 24, 2019 •
edited by hazzik
Loading

Fixes #1993

@offan offan changed the title NHTest System.InvalidCastException when merge collenction with LazyProperty Jan 24, 2019
@offan offan changed the title System.InvalidCastException when merge collenction with LazyProperty Add test for System.InvalidCastException when merge collenction with LazyProperty Jan 24, 2019
@maca88
Copy link
Contributor

maca88 commented Jan 24, 2019

Instead of porting Hibernate's fix, I've used the fix for NH-3374 which seems better to me.

@maca88 maca88 changed the title Add test for System.InvalidCastException when merge collenction with LazyProperty Fix for System.InvalidCastException when merge collenction with LazyProperty Jan 24, 2019
@hazzik hazzik changed the title Fix for System.InvalidCastException when merge collenction with LazyProperty Fix for System.InvalidCastException when merge collection with LazyProperty Jan 24, 2019
@hazzik hazzik added this to the 5.3 milestone Jan 24, 2019
@hazzik
Copy link
Member

hazzik commented Jan 24, 2019

Hi @offan thanks for the test. Don't need to create an issue when you create a PR.

@hazzik hazzik changed the title Fix for System.InvalidCastException when merge collection with LazyProperty Fix System.InvalidCastException when merge collection with LazyProperty Jan 24, 2019
@hazzik hazzik changed the title Fix System.InvalidCastException when merge collection with LazyProperty Fix System.InvalidCastException when merge collection has LazyProperty Jan 24, 2019
@hazzik hazzik changed the title Fix System.InvalidCastException when merge collection has LazyProperty Fix System.InvalidCastException when merge collection with LazyProperty Jan 24, 2019
@fredericDelaporte fredericDelaporte merged commit ef5986e into nhibernate:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

InvalidCastException when merging a collection with a lazy property
4 participants
@offan @maca88 @hazzik @fredericDelaporte