Optimize CriteriaQueryTranslator GetColumns and GetTypes #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added explicit tests with benchmarks which show that second point doesn't give any visible perf gain on my machine (but let it stay as it was done simply as part of subquery fix) But it gives visible boost for subqueries with many references from outer query (see SubqueryManyParamsFromOuterQuery). On my machine it's 6s vs 3s for 15000 query generations. |
hazzik
previously approved these changes
Jan 14, 2019
hazzik
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid catching exceptions for subqueries (fixes #780)
Avoid multiple path parsings and subcriteria lookups
Fixes GetType for multilevel subqueries (fixes #1312)