Do not generate FK on non-generated unique constraint #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is also a kind of follow-up to #1855, as the trouble here can happen only when using the feature fixed for another trouble there. It would be better to have that feature (I hope) fully fixed in 5.2. |
hazzik
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an unique key is not generated due to the database not supporting a
nullvalue in an unique key, foreign keys on the unique key must not be generated either.This is an old bug of the feature consisting in not generating unique constraints for nullable columns when the target database does not support null in unique. But as no dialects were enabling this feature, tests were not showcasing it.
#1854 enables a dialect with this feature, and its build fails due to FK being generated for non-generated unique constraints, see here.