Add an async enabled transaction synchronization #1864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
force-pushed
the
tranSync
branch
from
dba2708 to
19233ec
Compare
| } | ||
| } | ||
|
|
||
| // Since v5.2 |
There was a problem hiding this comment.
I have not written 5.3 but 5.2, in case we merge this in it.
| if (synchronization == null) | ||
| throw new ArgumentNullException(nameof(synchronization)); | ||
|
|
||
| // It is tempting to use the session ActionQueue instead, but stateless sessions do not have one. |
There was a problem hiding this comment.
So I do not see another way than keeping this additional way of doing things.
hazzik
reviewed
Oct 1, 2018
| } | ||
| })); | ||
| session.ConnectionManager.Transaction.RegisterSynchronization( | ||
| new AfterTransactionCompletion( |
There was a problem hiding this comment.
Can we have a proper class instead of this delegate-based unpleasantness?
Simplify old adapted code
hazzik
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1752