Fix SQLite/SqlCE validation failure on tables with a schema #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Jul 11, 2018
| { | ||
| case MsSql2000Dialect _: | ||
| case PostgreSQLDialect _: | ||
| case SQLiteDialect _: |
There was a problem hiding this comment.
SQL Ce uses the same pattern as SQLiteDialect
There was a problem hiding this comment.
Indeed, done two years later in e79f47e. Now I have checked Dialect.Qualify overrides, no other database does that, although Firebird and MySql do not support schema either.
(Firebird may be fixed by overriding Qualify for ignoring catalog and schema; I think it is better than introducing the hack in it. MySql should ideally be fixed for ignoring schema; but this may be a breaking change for people "benefiting" of the current behavior handling schema like a catalog (provided catalog is not supplied at the same time). Anyway both cases would have to be handled in another PRs.)
fredericDelaporte
changed the title
hazzik
previously approved these changes
Jul 11, 2018
Do the same for SQL-Server CE
fredericDelaporte
force-pushed
the
schemaValidation
branch
from
719538d to
a683e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609.
Fixes #1096.
See the issue comments, that is hacks all the way for fixing a hack from 2008. But reverting this ten years old hack is likely to be a big breaking change fro SQLite users, so well, I think it is still better to fix it that way.