Skip to content

Avoid a null reference exception in ExpressionKeyVisitor #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Jan 17, 2018

As seen within #1532, ExpressionKeyVisitor.Visit may blow with a null reference exception when a null constantToParameterMap is transmitted. But some code path always transmit this parameter as null, because they work on MemberExpression which does not have the trouble.

So we need to keep accepting null, but throw a better exception when a constantToParameterMap was indeed required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant