Skip to content

SQLite is bugged with distributed transactions: disable distributed tests #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2017
Merged

SQLite is bugged with distributed transactions: disable distributed tests #1506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/NHibernate/Dialect/SQLiteDialect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,17 @@ public override bool SupportsForeignKeyConstraintInAlterTable
/// </remarks>
public override bool SupportsConcurrentWritingConnections => false;

/// <summary>
/// Does this dialect supports distributed transaction? <c>false</c>.
/// </summary>
/// <remarks>
/// SQLite does not have a two phases commit and as such does not respect distributed transaction semantic.
/// But moreover, it fails handling the threading involved with distributed transactions (see
/// https://system.data.sqlite.org/index.html/tktview/5cee5409f84da5f62172 ).
/// It has moreover some flakyness in tests due to seemingly highly delayed (> 500ms) commits when distributed.
/// </remarks>
public override bool SupportsDistributedTransactions => false;

// Said to be unlimited. http://sqlite.1065341.n5.nabble.com/Max-limits-on-the-following-td37859.html
/// <inheritdoc />
public override int MaxAliasLength => 128;
Expand Down