Skip to content

Fix default types #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

Fix default types #1484

merged 1 commit into from
Dec 13, 2017

Conversation

fredericDelaporte
Copy link
Member

  • Remove logic duplication for getting default NHibernate type for a CLR type.
  • Test all defaults for CLR type having many possibilities.
  • Clean-up.

The test for decimal was failing, it was yielding Currency instead of Decimal.

@fredericDelaporte
Fix default types
9c5259a 
 * Remove logic duplication for getting default NHibernate type for a CLR type.
 * Test all defaults for CLR type having many possibilities.
 * Clean-up.
@hazzik
Copy link
Member

hazzik commented Dec 13, 2017

The test for decimal was failing, it was yielding Currency instead of Decimal.

I think there was an issue about something like that.

@hazzik
Copy link
Member

hazzik commented Dec 13, 2017

It was mentioned in #1052

@fredericDelaporte
Copy link
Member Author

It was mentioned in #1052

Ok, I will add a comment there about this point being resolved once this PR gets merged.

@hazzik hazzik merged commit 6d8d5d9 into nhibernate:master Dec 13, 2017
@hazzik hazzik added this to the 5.1 milestone Dec 13, 2017
@fredericDelaporte fredericDelaporte mentioned this pull request Dec 13, 2017
Closed
@fredericDelaporte fredericDelaporte deleted the FixDefaultType branch December 13, 2017 12:36
@fredericDelaporte fredericDelaporte mentioned this pull request Jan 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: Core p: Minor r: Fixed t: Bug
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericDelaporte @hazzik