Fix disposing SessionIdLoggingContext if CheckAndUpdateSessionStatus is failed #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will go to 5.0.3 |
hazzik
force-pushed
the
process-helper-fix
branch
from
7349af8 to
7f84042
Compare
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| _context.Dispose(); |
There was a problem hiding this comment.
If disposed is called multiple times, this will cause a null ref. We need a ?. here.
|
Thanks for the fix. The additional point I have mentioned should be fixed in 5.1 I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.