Skip to content

Release 5.0.2 #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2017
Merged

Release 5.0.2 #1457

merged 3 commits into from
Nov 29, 2017

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Nov 28, 2017

I guess we do not have more things to add in 5.0.2, so here is the release PR.

Release draft is view-able for NHibernate team here.

Elaborated from a draft generated with:

GitReleaseManager.exe create -o nhibernate -r nhibernate-core -m 5.0.2 -c 5.0.x -u username -p password

(If you test it, it announces 14 commits because it counts on master in spite of the -c 5.0.x which told it the branch. That parameter is still useful for correctly setting the target of the draft release.)

The GitReleaseManager settings have been updated for handling new tags.

I have also added a commit for retro-documenting a missing possible breaking change of 5.0.0.

@fredericDelaporte fredericDelaporte added this to the 5.0.2 milestone Nov 28, 2017
@fredericDelaporte fredericDelaporte force-pushed the 5.0.2 branch 2 times, most recently from a5cb3dd to d3894e9 Compare November 28, 2017 13:13
@hazzik
Copy link
Member

hazzik commented Nov 28, 2017

I've moved #1455 to bugs, as it is technically a bugfix. Could you please regenerated the release notes?

Copy link
Member

@hazzik hazzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the comment above.

@fredericDelaporte
Copy link
Member Author

Adjusted. I intend to do the release tomorrow.

@fredericDelaporte fredericDelaporte merged commit 4e7fbc7 into nhibernate:5.0.x Nov 29, 2017
@fredericDelaporte fredericDelaporte deleted the 5.0.2 branch November 29, 2017 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants