Documentation fixes #1379
Merged
Documentation fixes #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +79,7 @@ public static string Version | |||
| public const string ConnectionStringName = "connection.connection_string_name"; | |||
|
|
|||
| // Unused, Java-specific | |||
| // But has many code usage though. | |||
| public const string SessionFactoryName = "session_factory_name"; | |||
There was a problem hiding this comment.
Not switched to obsolete because its many code usages imply a lot of changes, and so I am not sure it has really not any use. (And I do not intend to investigate further the subject.)
| // support the version taking an array of the names of the columns to | ||
| // be returned (via its RETURNING clause). No other driver seems to | ||
| // support this overloaded version. | ||
| DefaultProperties[Environment.UseGetGeneratedKeys] = "false"; |
There was a problem hiding this comment.
This thing was set but never read. Its corresponding feature is not implemented.
hazzik
approved these changes
Oct 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788, #823, #824, #1165 and #1179. (This time I have tested generating the doc locally before issuing the PR.)