Same column name in Id and in Many-To-One mapping causes error

[heikar]

Hi,

the following mapping fails because of the id column:

public class ArticleMap : ClassMapping<Article>
{
public Article()
{
Id(x => x.Id, x => x.Column("Id"));
Property(x => x.Name);
Property(x => x.Description);
ManyToOne(x => x.Dimensions, map => map.Name("Id"));
}
}

If i change it to:

public class ArticleMap : ClassMapping<Article>
{
public Article()
{
Id(x => x.Id, x => x.Column("Id"));
Property(x => x.Name);
Property(x => x.Description);
ManyToOne(x => x.Dimensions, map => map.Name("ID"));
}
}

it works for SELECT but for UPDATE and INSERT, the behavior is strange.

The generated INSERT command is: INSERT INTO Article (Name, Description, ID, Id) VALUES (?, ?, ?, ?).
The generated UPDATE command is: UPDATE Article SET Name = ?, Description = ?, ID = ? WHERE Id = ?.

Many greetings,
heikar

[deAtog]

I believe both issues are caused by #1875. See #2423 for more information and further discussion.

[fredericDelaporte]

This issue is answered in release notes:

nhibernate-core/releasenotes.txt

Lines 145 to 149 in 752fd62

	* Entities having many non-readonly properties (including many-to-one) mapped to
	the same column will no more silently ignore the trouble till an insert or update
	is attempted. They will now cause the session factory built to fail. When
	mapping many properties to the same column, all of them excepted at most one
	should be mapped with `insert="false" update="false"`.

You have to map your association as readonly.

ManyToOne(
    x => x.Dimensions,
    map =>
    {
        map.Column("Id");
        map.Insert(false);
        map.Update(false);
    });

And your report is also a duplicate of #2001.

[deAtog]

@fredericDelaporte I think there may still be an issue here. Changing the case of a column name shouldn't bypass the duplicate column exception and generate incorrect insert and update statements.

[fredericDelaporte]

We can not know: it depends on the database or even the database setting (SQL Server case). Database object names may be case sensitive, and NHibernate has no knowledge of whether this is the case or not.

[deAtog]

@fredericDelaporte yeah, I thought that might be the case. I think I recall running into something similar with MySql on Linux.