[core] Add support for comma format #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhairs
commented
May 26, 2025
Comment on lines
+280
to
+283
| if self._fmt is None: | ||
| # TODO: does it matter that we do this before checking if the style is valid? | ||
| # (we already (mostly) check for valid style names in __init__ | ||
| return [] |
There was a problem hiding this comment.
Does it matter that we do this before checking if the style is valid?
We already (mostly) check for valid style names in __init__
nhairs
commented
May 26, 2025
Comment on lines
+285
to
+290
| if isinstance(self._style, str) and self._style == ",": | ||
| # TODO: should we check that there are no empty fields? | ||
| # If yes we should do this in __init__ where we validate other styles? | ||
| # Do we drop empty fields? | ||
| # etc | ||
| return [field.strip() for field in self._fmt.split(",") if field.strip()] |
There was a problem hiding this comment.
Should we check that there are no empty fields?
If yes we should do this in __init__ where we validate other styles?
Is it okay that we drop empty fields?
etc
nhairs
commented
May 26, 2025
| @@ -285,10 +303,7 @@ def parse(self) -> List[str]: | |||
| else: | |||
| raise ValueError(f"Style {self._style!r} is not supported") | |||
There was a problem hiding this comment.
This needs updating. Probably need to find a different representation since $,%,{,, isn't exactly intuitive...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Test Plan
To Do
TODOcomments.