Small fixes to the NGINX Plus client #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Total responses to upstream struct - Add json tag to HealthChecks property so it parses - Update comment
pleshakov
reviewed
Jun 15, 2018
client/nginx_client.go
Outdated
| @@ -108,6 +108,7 @@ type Responses struct { | |||
| Responses3xx uint64 `json:"3xx"` | |||
| Responses4xx uint64 `json:"4xx"` | |||
| Responses5xx uint64 `json:"5xx"` | |||
| Total uint64 `json:"total"` | |||
There was a problem hiding this comment.
is json:"total" requried?
There was a problem hiding this comment.
Looks so weird without it
client/nginx_client.go
Outdated
| @@ -12,7 +12,7 @@ import ( | |||
| // APIVersion is a version of NGINX Plus API. | |||
| const APIVersion = 2 | |||
|
|
|||
| // NginxClient lets you add/remove servers to/from NGINX Plus via its API. | |||
| // NginxClient lets you access NGINX Plus via its API. | |||
There was a problem hiding this comment.
NginxClient lets you access NGINX Plus via its API. -> NginxClient lets you access NGINX Plus API.
imho
|
I haven't added a sleep, and one isn't necessary imho, the test is fine with 0 values in the healthcheck. |
- Fix comment - Fix inconsistent test error string case
Dean-Coakley
approved these changes
Jun 15, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If you add a 5s sleep before fetching upstream stats you can see the HealthChecks populated)