Skip to content

Fix go style #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Fix go style #11

merged 2 commits into from
Sep 25, 2018

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Simplify tests with gofmt -s. (Found by goreportcard)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

* Run test files through gofmt -s for goreportcard
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dean-Coakley

in your fix, incorrect formatting was applied to nginx_test.go. please double check

@Dean-Coakley
Copy link
Contributor Author

Should be good now @pleshakov

@Dean-Coakley Dean-Coakley self-assigned this Sep 24, 2018
@Dean-Coakley Dean-Coakley merged commit 1900f9f into nginx:master Sep 25, 2018
@Dean-Coakley Dean-Coakley deleted the go-style-fixes branch September 25, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants