Skip to content

Disable unsused controllers #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Disable unsused controllers #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Follow our [Installation Instructions](README.md#run-nginx-gateway) to get the N
* The internal code is found at `internal/`
* Build files for Docker are found under `build/`
* Deployment yaml files are found at `deploy/`
* External APIs, clients, and SDKs can be found under `pkg/`
* We use [Go Modules](https://github.com/golang/go/wiki/Modules) for managing dependencies.
* We use [Ginkgo](https://onsi.github.io/ginkgo/) and [Gomega](https://onsi.github.io/gomega/) for our BDD style unit tests.

Expand Down
6 changes: 0 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ You can deploy NGINX Kubernetes Gateway on an existing Kubernetes 1.16+ cluster.
```
kubectl apply -k "github.com/kubernetes-sigs/gateway-api/config/crd?ref=v0.4.2"
```

1. Install the NGINX Kubernetes Gateway CRDs:

```
kubectl apply -f deploy/manifests/crds
```

1. Deploy the NGINX Kubernetes Gateway:

Expand Down
17 changes: 0 additions & 17 deletions internal/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,13 @@ import (

"github.com/nginxinc/nginx-kubernetes-gateway/internal/config"
"github.com/nginxinc/nginx-kubernetes-gateway/internal/events"
gw "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/gateway"
gc "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/gatewayclass"
gcfg "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/gatewayconfig"
hr "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/httproute"
svc "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/service"
ngxcfg "github.com/nginxinc/nginx-kubernetes-gateway/internal/nginx/config"
"github.com/nginxinc/nginx-kubernetes-gateway/internal/nginx/file"
ngxruntime "github.com/nginxinc/nginx-kubernetes-gateway/internal/nginx/runtime"
"github.com/nginxinc/nginx-kubernetes-gateway/internal/state"
"github.com/nginxinc/nginx-kubernetes-gateway/internal/status"
nginxgwv1alpha1 "github.com/nginxinc/nginx-kubernetes-gateway/pkg/apis/gateway/v1alpha1"
"github.com/nginxinc/nginx-kubernetes-gateway/pkg/sdk"
)

Expand All @@ -34,7 +30,6 @@ var scheme = runtime.NewScheme()
func init() {
// TO-DO: handle errors returned by the calls bellow
_ = gatewayv1alpha2.AddToScheme(scheme)
_ = nginxgwv1alpha1.AddToScheme(scheme)
_ = apiv1.AddToScheme(scheme)
}

Expand All @@ -55,18 +50,6 @@ func Start(cfg config.Config) error {
return fmt.Errorf("cannot build runtime manager: %w", err)
}

err = sdk.RegisterGatewayController(mgr, gw.NewGatewayImplementation(cfg))
if err != nil {
return fmt.Errorf("cannot register gateway implementation: %w", err)
}
err = sdk.RegisterGatewayClassController(mgr, gc.NewGatewayClassImplementation(cfg))
if err != nil {
return fmt.Errorf("cannot register gatewayclass implementation: %w", err)
}
err = sdk.RegisterGatewayConfigController(mgr, gcfg.NewGatewayConfigImplementation(cfg))
if err != nil {
return fmt.Errorf("cannot register gatewayconfig implementation: %w", err)
}
err = sdk.RegisterHTTPRouteController(mgr, hr.NewHTTPRouteImplementation(cfg, eventCh))
if err != nil {
return fmt.Errorf("cannot register httproute implementation: %w", err)
Expand Down