-
Notifications
You must be signed in to change notification settings - Fork 118
Add fix to route parentRef internal logic #3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
==========================================
- Coverage 86.82% 86.74% -0.09%
==========================================
Files 127 127
Lines 15020 15068 +48
Branches 62 62
==========================================
+ Hits 13041 13070 +29
- Misses 1830 1846 +16
- Partials 149 152 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'd also add a release note that describes this bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
60037d7
to
d3002bc
Compare
d3002bc
to
c84872f
Compare
Proposed changes
Internally generate ParentRefs for each listener in the Gateway if a route does not specify a sectionName.
Problem: When a route does not specify a sectionName, it attaches to all attachable listeners on a Gateway. This is a problem internally when we try to bind the route to the listeners where duplicated hostnames between listeners can create AcceptedHostname conflicts and multiple ports on the listeners can overwrite the refStatus.ListenerPort.
Solution: When a route does not specify a sectionName, generate a ParentRef for each listener in the Gateway.
Testing: Manually tested that the scenario reported in #3400 does not occur anymore.
Closes #3400
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.