Skip to content

CP/DP Split: fix label updates #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented May 13, 2025

Problem: Updating labels/annotations on the Gateway did not propagate to some resources.

Solution: Ensure that labels/annotations are set when updating resources.

Also removed some unnecessary conditions and the "connection" agent feature.

Testing: Verified that labels/annotations are updated properly

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: Updating labels/annotations on the Gateway did not propagate to some resources.

Solution: Ensure that labels/annotations are set when updating resources.
@sjberman sjberman requested a review from a team as a code owner May 13, 2025 14:59
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels May 13, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (dca6b4b) to head (d9ab5f9).
Report is 1 commits behind head on change/control-data-plane-split.

Files with missing lines Patch % Lines
internal/mode/static/provisioner/setter.go 81.08% 7 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3370      +/-   ##
===================================================================
+ Coverage                            86.65%   86.77%   +0.12%     
===================================================================
  Files                                  129      129              
  Lines                                14855    14862       +7     
  Branches                                62       62              
===================================================================
+ Hits                                 12872    12897      +25     
+ Misses                                1834     1817      -17     
+ Partials                               149      148       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman merged commit 5abe667 into change/control-data-plane-split May 14, 2025
56 of 58 checks passed
@sjberman sjberman deleted the chore/labels branch May 14, 2025 15:50
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric May 14, 2025
sjberman added a commit that referenced this pull request May 14, 2025
Problem: Updating labels/annotations on the Gateway did not propagate to some resources.

Solution: Ensure that labels/annotations are set when updating resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants