Skip to content

Docs: Fix broken redirect in usage-reporting.md #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Docs: Fix broken redirect in usage-reporting.md #2616

merged 1 commit into from
Sep 27, 2024

Conversation

nginx-aoife
Copy link
Contributor

@nginx-aoife nginx-aoife commented Sep 27, 2024

Proposed changes

Problem: The link to the NIM product page in the Usage Reporting guide is a broken redirect. User gets a 404.

Solution: Updating the link to point to the actual F5 NIM product page

Testing: n/a

Please also Merge if approved

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@nginx-aoife nginx-aoife requested review from a team as code owners September 27, 2024 11:10
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (4aa68d7) to head (139e456).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2616   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         105      105           
  Lines        8109     8109           
  Branches       50       50           
=======================================
  Hits         7187     7187           
  Misses        865      865           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADubhlaoich ADubhlaoich merged commit 900c877 into nginx:main Sep 27, 2024
40 checks passed
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants