Add hugo version check and theme update to Makefile #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md with correct make target behaviors Add hugo-entrypoint to allow extra commands when docker starts Update hugo theme version in go.mod Use slimmer hugo docker image
|
Hi @nginx-jack! Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 105 105
Lines 8116 8116
Branches 50 50
=======================================
Hits 7193 7193
Misses 866 866
Partials 57 57 ☔ View full report in Codecov by Sentry. |
ADubhlaoich
approved these changes
Sep 26, 2024
sjberman
approved these changes
Sep 26, 2024
kate-osborn
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Confirmed it works locally without hugo installed. Thanks @nginx-jack!
nginx-jack
added a commit
to nginx-jack/nginx-gateway-fabric
that referenced
this pull request
Oct 2, 2024
Update README.md with correct make target behaviors Add hugo-entrypoint to allow extra commands when docker starts Update hugo theme version in go.mod Use slimmer hugo docker image
ADubhlaoich
pushed a commit
that referenced
this pull request
Oct 2, 2024
salonichf5
pushed a commit
that referenced
this pull request
Oct 8, 2024
Update README.md with correct make target behaviors Add hugo-entrypoint to allow extra commands when docker starts Update hugo theme version in go.mod Use slimmer hugo docker image
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Update README.md with correct make target behaviors Add hugo-entrypoint to allow extra commands when docker starts Update hugo theme version in go.mod Use slimmer hugo docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This should help prevent any hugo or hugo-theme version drift going forward, and warn when versions are out of date.
Closes #2544
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.