Skip to content

Replace prettier mirror in pre-commit #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Replace prettier mirror in pre-commit #2464

merged 2 commits into from
Aug 27, 2024

Conversation

lucacome
Copy link
Contributor

Proposed changes

Problem: pre-commit/mirrors-prettier was archived without any explanation and it previously stopped using the right tags.

Solution: replace it with a fork, rbubley/mirrors-prettier

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: pre-commit/mirrors-prettier was archived without any explanation and it
previously stopped using the right tags.

Solution: replace it with a fork, rbubley/mirrors-prettier
@lucacome lucacome requested a review from a team as a code owner August 23, 2024 21:22
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (964877f) to head (53094b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2464   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         100      100           
  Lines        7531     7531           
  Branches       50       50           
=======================================
  Hits         6687     6687           
  Misses        788      788           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) August 27, 2024 05:10
@lucacome lucacome merged commit 54a635d into nginx:main Aug 27, 2024
37 checks passed
@lucacome lucacome deleted the chore/replace-prettier branch September 12, 2024 17:20
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: pre-commit/mirrors-prettier was archived without any explanation and it
previously stopped using the right tags.

Solution: replace it with a fork, rbubley/mirrors-prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants