-
Notifications
You must be signed in to change notification settings - Fork 117
Add 1.3 reconfig test results #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
# Reconfiguration testing Results | ||
|
||
<!-- TOC --> | ||
- [Reconfiguration testing Results](#reconfiguration-testing-results) | ||
- [Summary](#summary) | ||
- [Test environment](#test-environment) | ||
- [Results Tables](#results-tables) | ||
- [NGINX Reloads and Time to Ready](#nginx-reloads-and-time-to-ready) | ||
- [Event Batch Processing](#event-batch-processing) | ||
- [NumResources to Total Resources](#numresources-to-total-resources) | ||
- [Observations](#observations) | ||
- [Future Improvements](#future-improvements) | ||
<!-- TOC --> | ||
|
||
## Summary | ||
|
||
- Due to fix https://github.com/nginxinc/nginx-gateway-fabric/issues/1107, time to ready, reload time, and event batch processing | ||
time increased for all 150 resource tests. | ||
- For all 30 resource tests, results were mostly consistent to prior results. | ||
|
||
## Test environment | ||
|
||
GKE cluster: | ||
|
||
- Node count: 3 | ||
- Instance Type: e2-medium | ||
- k8s version: 1.28.9-gke.1000000 | ||
- Zone: us-central1-c | ||
- Total vCPUs: 6 | ||
- Total RAM: 12GB | ||
- Max pods per node: 110 | ||
|
||
NGF deployment: | ||
|
||
- NGF version: edge - git commit 7c9bf23ed89861c9ce7b725f2c1686f4c24ef2f9 | ||
- NGINX OSS Version: 1.27.0 | ||
- NGINX Plus Version: R32 | ||
|
||
## Results Tables | ||
|
||
### NGINX Reloads and Time to Ready | ||
|
||
#### OSS | ||
|
||
| Test number | NumResources | TimeToReadyTotal (s) | TimeToReadyAvgSingle (s) | NGINX reloads | NGINX reload avg time (ms) | <= 500ms | <= 1000ms | | ||
|-------------|--------------|----------------------|--------------------------|---------------|----------------------------|----------|-----------| | ||
| 1 | 30 | 2 | <1 | 2 | 190 | 100% | 100% | | ||
| 1 | 150 | 2 | <1 | 2 | 542 | 50% | 100% | | ||
| 2 | 30 | 37 | <1 | 94 | 169 | 100% | 100% | | ||
| 2 | 150 | 204 | <1 | 387 | 326 | 88% | 100% | | ||
| 3 | 30 | <1 | <1 | 94 | 129 | 100% | 100% | | ||
| 3 | 150 | <1 | <1 | 454 | 130 | 100% | 100% | | ||
|
||
#### Plus | ||
|
||
| Test number | NumResources | TimeToReadyTotal (s) | TimeToReadyAvgSingle (s) | NGINX reloads | NGINX reload avg time (ms) | <= 500ms | <= 1000ms | | ||
|-------------|--------------|----------------------|--------------------------|---------------|----------------------------|----------|-----------| | ||
| 1 | 30 | 1 | <1 | 2 | 220.5 | 100% | 100% | | ||
| 1 | 150 | 1.5 | <1 | 2 | 528.5 | 50% | 100% | | ||
| 2 | 30 | 41 | <1 | 94 | 176.8 | 100% | 100% | | ||
| 2 | 150 | 199 | <1 | 391 | 320.56 | 94.1% | 100% | | ||
| 3 | 30 | <1 | <1 | 94 | 128.5 | 100% | 100% | | ||
| 3 | 150 | <1 | <1 | 454 | 129.2 | 100% | 100% | | ||
|
||
### Event Batch Processing | ||
|
||
#### OSS | ||
|
||
| Test number | NumResources | Event Batch Total | Event Batch Processing avg time (ms) | <= 500ms | <= 1000ms | <= 5000ms | <= 10000ms | <= 30000ms | | ||
|-------------|--------------|-------------------|--------------------------------------|----------|-----------|-----------|------------|------------| | ||
| 1 | 30 | 5 | 726.6 | 80% | 80% | 100% | 100% | 100% | | ||
| 1 | 150 | 5 | 4457 | 40% | 80% | 80% | 80% | 100% | | ||
| 2 | 30 | 371 | 59.5 | 99.7% | 100% | 100% | 100% | 100% | | ||
| 2 | 150 | 1742 | 93.5 | 92.9% | 99.99% | 100% | 100% | 100% | | ||
| 3 | 30 | 370 | 43.9 | 99.85% | 99.85% | 100% | 100% | 100% | | ||
| 3 | 150 | 1810 | 44.8 | 99.99% | 99.99% | 99.99% | 100% | 100% | | ||
|
||
#### Plus | ||
|
||
| Test number | NumResources | Event Batch Total | Event Batch Processing avg time (ms) | <= 500ms | <= 1000ms | <= 5000ms | <= 10000ms | <= 30000ms | | ||
|-------------|--------------|-------------------|--------------------------------------|----------|-----------|-----------|------------|--------------| | ||
| 1 | 30 | 6 | 84 | 100% | 100% | 100% | 100% | 100% | | ||
| 1 | 150 | 5 | 4544.3 | 40% | 80% | 80% | 80% | 100% | | ||
| 2 | 30 | 370 | 59.1 | 100% | 100% | 100% | 100% | 100% | | ||
| 2 | 150 | 1747 | 93.2 | 94.1% | 99.99% | 100% | 100% | 100% | | ||
| 3 | 30 | 370 | 41.33 | 99.99% | 99.99% | 100% | 100% | 100% | | ||
| 3 | 150 | 1809 | 44.88 | 99.99% | 99.99% | 99.99% | 99.99% | 100% | | ||
|
||
## NumResources to Total Resources | ||
|
||
| NumResources | Gateways | Secrets | ReferenceGrants | Namespaces | application Pods | application Services | HTTPRoutes | Total Resources | | ||
|--------------|----------|---------|-----------------|------------|------------------|----------------------|------------|-----------------| | ||
| x | 1 | 1 | 1 | x+1 | 2x | 2x | 3x | <total> | | ||
| 30 | 1 | 1 | 1 | 31 | 60 | 60 | 90 | 244 | | ||
| 150 | 1 | 1 | 1 | 151 | 300 | 300 | 450 | 1204 | | ||
|
||
## Observations | ||
|
||
1. Reload time and time to ready have increased in 150 resource tests. This is probably due, in part, to the fix of https://github.com/nginxinc/nginx-gateway-fabric/issues/1107 causing the prior | ||
test to only attach 2x of the HTTPRoutes while this test attaches all of them. In the 30 resource tests, results were mostly consistent to prior results. | ||
|
||
2. Event batch processing time increased notably in the 150 resource tests, probably for the same reason mentioned in observation #1. | ||
In the 30 resource tests, results were mostly consistent to prior results. | ||
|
||
3. No errors in the logs. | ||
|
||
|
||
## Future Improvements | ||
|
||
None. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.