Skip to content

Document cli args and Gateway API compatibility #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 19, 2022
Merged

Conversation

pleshakov
Copy link
Contributor

Proposed changes

  • Add cli args doc
  • Fix the description of the gateway-ctlr-name cli arg
  • Add Gateway APi compatibility doc

- Add cli args doc
- Fix the description of the gateway-ctlr-name cli arg
- Add Gateway APi compatibility doc
@pleshakov pleshakov requested a review from a team August 19, 2022 00:27
@kate-osborn
Copy link
Contributor

@pleshakov can you add links to the new docs to the README?

pleshakov and others added 12 commits August 19, 2022 11:47
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
@pleshakov
Copy link
Contributor Author

@kate-osborn

can you add links to the new docs to the README?

better to do it after #203 is merged

@pleshakov pleshakov requested a review from kate-osborn August 19, 2022 18:16
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, I think this doc will be super helpful!

@kate-osborn
Copy link
Contributor

@kate-osborn

can you add links to the new docs to the README?

better to do it after #203 is merged

I can add the link. I think this will be merged before 203.

@pleshakov pleshakov requested a review from f5yacobucci August 19, 2022 19:51
@pleshakov pleshakov merged commit c5d5cf0 into main Aug 19, 2022
@pleshakov pleshakov deleted the docs/api-compatibility branch August 19, 2022 21:06
pleshakov added a commit that referenced this pull request Aug 19, 2022
- Add cli args doc
- Fix the description of the gateway-ctlr-name cli arg
- Add Gateway APi compatibility doc

Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
(cherry picked from commit c5d5cf0)
@lucacome lucacome added the documentation Improvements or additions to documentation label Oct 24, 2022
@pleshakov pleshakov added the skip-changelog Pull requests that don't need to be added to the changelog. label Oct 24, 2022
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
- Add cli args doc
- Fix the description of the gateway-ctlr-name cli arg
- Add Gateway APi compatibility doc

Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Pull requests that don't need to be added to the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants