Skip to content

Remove deprecated ioutil library #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions internal/state/file_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package state

import (
"io/fs"
"io/ioutil"
"os"
)

Expand All @@ -12,8 +11,8 @@ func newStdLibFileManager() *stdLibFileManager {
return &stdLibFileManager{}
}

func (s *stdLibFileManager) ReadDir(dirname string) ([]fs.FileInfo, error) {
return ioutil.ReadDir(dirname)
func (s *stdLibFileManager) ReadDir(dirname string) ([]fs.DirEntry, error) {
return os.ReadDir(dirname)
}

func (s *stdLibFileManager) Remove(name string) error {
Expand Down
6 changes: 3 additions & 3 deletions internal/state/secrets.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . SecretStore
//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . SecretDiskMemoryManager
//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . FileManager
//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 io/fs.FileInfo
//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 io/fs.DirEntry

// tlsSecretFileMode defines the default file mode for files with TLS Secrets.
const tlsSecretFileMode = 0o600
Expand Down Expand Up @@ -78,8 +78,8 @@ type SecretDiskMemoryManager interface {
// FileManager is an interface that exposes File I/O operations.
// Used for unit testing.
type FileManager interface {
// ReadDir returns the file info for the directory.
ReadDir(dirname string) ([]fs.FileInfo, error)
// ReadDir returns the directory entries for the directory.
ReadDir(dirname string) ([]fs.DirEntry, error)
// Remove file with given name.
Remove(name string) error
// Create file at the provided filepath.
Expand Down
19 changes: 9 additions & 10 deletions internal/state/secrets_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ package state_test
import (
"errors"
"io/fs"
"io/ioutil"
"os"
"path"

Expand Down Expand Up @@ -201,7 +200,7 @@ var _ = Describe("SecretDiskMemoryManager", func() {
expectedFileNames := []string{"test_secret1", "test_secret2"}

// read all files from directory
dir, err := ioutil.ReadDir(tmpSecretsDir)
dir, err := os.ReadDir(tmpSecretsDir)
Expect(err).ToNot(HaveOccurred())

// test that the files exist that we expect
Expand All @@ -222,7 +221,7 @@ var _ = Describe("SecretDiskMemoryManager", func() {
Expect(err).ToNot(HaveOccurred())

// read all files from directory
dir, err := ioutil.ReadDir(tmpSecretsDir)
dir, err := os.ReadDir(tmpSecretsDir)
Expect(err).ToNot(HaveOccurred())

// only the secrets stored after the last write should be written to disk.
Expand All @@ -235,7 +234,7 @@ var _ = Describe("SecretDiskMemoryManager", func() {
Expect(err).ToNot(HaveOccurred())

// read all files from directory
dir, err := ioutil.ReadDir(tmpSecretsDir)
dir, err := os.ReadDir(tmpSecretsDir)
Expect(err).ToNot(HaveOccurred())

// no secrets should exist
Expand All @@ -245,16 +244,16 @@ var _ = Describe("SecretDiskMemoryManager", func() {
})
Describe("Write all requested secrets", func() {
var (
fakeFileManager *statefakes.FakeFileManager
fakeStore *statefakes.FakeSecretStore
fakeFileInfoSlice []fs.FileInfo
memMgr *state.SecretDiskMemoryManagerImpl
fakeFileManager *statefakes.FakeFileManager
fakeStore *statefakes.FakeSecretStore
fakeDirEntries []fs.DirEntry
memMgr *state.SecretDiskMemoryManagerImpl
)

BeforeEach(OncePerOrdered, func() {
fakeFileManager = &statefakes.FakeFileManager{}
fakeStore = &statefakes.FakeSecretStore{}
fakeFileInfoSlice = []fs.FileInfo{&statefakes.FakeFileInfo{}}
fakeDirEntries = []fs.DirEntry{&statefakes.FakeDirEntry{}}
memMgr = state.NewSecretDiskMemoryManager("", fakeStore, state.WithSecretFileManager(fakeFileManager))

// populate a requested secret
Expand All @@ -276,7 +275,7 @@ var _ = Describe("SecretDiskMemoryManager", func() {
}),
Entry("remove file error", errors.New("remove file"),
func(e error) {
fakeFileManager.ReadDirReturns(fakeFileInfoSlice, nil)
fakeFileManager.ReadDirReturns(fakeDirEntries, nil)
fakeFileManager.RemoveReturns(e)
}),
Entry("create file error", errors.New("create error"),
Expand Down
Loading