HTTPS Termination #140
Merged
HTTPS Termination #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
commented
Jul 12, 2022
pleshakov
suggested changes
Jul 14, 2022
added 26 commits
July 18, 2022 17:40
This commit adds support for HTTPS listeners with a TLS mode of Terminate. Multiple HTTPS listeners are supported provided their hostnames do not conflict. Additionally, a gateway can have an HTTP and HTTPS listener with the same hostname. Limitations: - HTTPS listeners must listen on port 443 - Supports a single reference to a Kubernetes Secret of type kubernetes.io/tls - Secret must be in the same namespace as the Gateway - Secret must be created before the HTTPRoutes are created - Secret rotation is not supported
kate-osborn
force-pushed
the
tls-termination
branch
from
10a9e0e to
f2b6cbe
Compare
added 2 commits
July 19, 2022 11:07
pleshakov
suggested changes
Jul 20, 2022
There was a problem hiding this comment.
hi @kate-osborn
a few more suggestions and questions based on the new code
added 8 commits
July 21, 2022 09:28
pleshakov
reviewed
Jul 22, 2022
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
* HTTPS Termination This commit adds support for HTTPS listeners with a TLS mode of Terminate. Multiple HTTPS listeners are supported provided their hostnames do not conflict. Additionally, a gateway can have an HTTP and HTTPS listener with the same hostname. Limitations: - HTTPS listeners must listen on port 443 - Supports a single reference to a Kubernetes Secret of type kubernetes.io/tls - Secret must be in the same namespace as the Gateway - Secret must be created before the HTTPRoutes are created - Secret rotation is not supported - SNI enforcement is not implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for HTTPS listeners with a TLS mode of Terminate.
Multiple HTTPS listeners are supported provided their hostnames do not conflict.
Additionally, a gateway can have an HTTP and HTTPS listener with the same
hostname.
Limitations:
Checklist