Skip to content

Ensure dataplane.Configuration related types don't include v1beta1 types #660

Closed
@kate-osborn

Description

@kate-osborn

Ensure dataplane.Configuration -related types don't include v1beta1 types:

  • This way we don't need to make any validation-related assumptions about them (ex. certain fields cannot be not nil)
  • Also, having dataplane.Configuration separate from Gateway API resources should make it easier to maintain/extend and potentially allow for supporting more routing resource types (outside of Gateway API) in the future.
  • It will simplify unit tests in the configs package.

FIXME in the code -- https://github.com/nginxinc/nginx-gateway-kubernetes/blob/890fddb787ff3560b9b743647a36b649d498ae51/internal/nginx/config/servers.go#L135

Metadata

Metadata

Assignees

Labels

refinedRequirements are refined and the issue is ready to be implemented.size/mediumEstimated to be completed within a weektech-debtShort-term pain, long-term benefit

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions