Skip to content

Set ResolvedRef Condition to True in HTTPRoute status when all references are resolved #611

Closed
@pleshakov

Description

@pleshakov

Gateway API prescribes setting ResolvedRef condition
https://github.com/kubernetes-sigs/gateway-api/blob/c67f3fd31976ea74ea06a78c2a88ae38df95a41d/apis/v1beta1/shared_types.go#L255-L290

NKG already implements it -- https://github.com/nginxinc/nginx-kubernetes-gateway/blob/f74c06ded5c3d647b0909fe542f3e70dbc96774c/internal/state/conditions/conditions.go#L253-L295 -- however, only when references are not resolved.

Implement the happy path case when references are resolved.

Also, conformance tests require it. Example: https://github.com/kubernetes-sigs/gateway-api/blob/6efcfdf8aff7aa7c3ed8deb956e5b93eed779234/conformance/tests/httproute-matching.go#L46

Acceptance criteria:

Metadata

Metadata

Assignees

Labels

area/httproute/coreRelates to all Core features of HTTPRouteconformanceRelates to passing Gateway API conformance testsenhancementNew feature or requestrefinedRequirements are refined and the issue is ready to be implemented.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions