Skip to content

Lint action missing errors on PRs #1136

Closed
@kate-osborn

Description

@kate-osborn

Describe the bug
The lint action passed on the PR but failed on the merge to main.

PR run: https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/6499218551
Merge to main run: https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/6499802831/job/17654089998

The pre-commit hook also missed this error.

Expected behavior

  • All lint errors should be caught before merging a PR to main.
  • Pre-commit hook should catch all lint errors

Metadata

Metadata

Assignees

Labels

chorePull requests for routine tasks

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions