generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 89
fix: Update cert instructions for NGINX One Console #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
dab1f07
to
726fa7a
Compare
mjang
commented
Jan 27, 2025
acad945
to
1707032
Compare
ADubhlaoich
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, added edit suggestions for some Hugo formatting/file style things.
mjang
commented
Jan 29, 2025
sylwang
reviewed
Jan 29, 2025
bheftel
reviewed
Jan 29, 2025
sylwang
reviewed
Jan 30, 2025
mjang
commented
Jan 31, 2025
mjang
commented
Jan 31, 2025
bheftel
reviewed
Jan 31, 2025
sylwang
approved these changes
Feb 4, 2025
1dd4a56
to
b7cf0b3
Compare
mjang
commented
Feb 5, 2025
6e559ad
to
62eb725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problems:
Lack of clarity in certificates. NGINX supports certificates in three categories:
Similar processes for adding / editing certs in an Instance / Config Sync Group
Clarification needed on the types of certs that are supported
Solution:
Closes #76
Checklist
Before creating a PR, run through this checklist and mark each as complete.
I have read the contributing guidelines
I have signed the F5 Contributor License Agreement (CLA)
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
I have updated any relevant documentation (
README.md
andCHANGELOG.md
)I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
If the change involves:
<username>
in place of PIIIn these cases, the change will require at least two (2) approvals before merging