Skip to content

fix: Update cert instructions for NGINX One Console #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jan 21, 2025

Proposed changes

Problems:

Lack of clarity in certificates. NGINX supports certificates in three categories:

  • Website traffic (typically purchased from a CA)
  • Repo verification
  • F5 License verification

Similar processes for adding / editing certs in an Instance / Config Sync Group

Clarification needed on the types of certs that are supported

Solution:

Closes #76

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/82/

@mjang mjang self-assigned this Jan 21, 2025
@mjang mjang force-pushed the update-n1console-diff-certs branch from dab1f07 to 726fa7a Compare January 24, 2025 21:12
@mjang mjang force-pushed the update-n1console-diff-certs branch 2 times, most recently from acad945 to 1707032 Compare January 28, 2025 20:50
@mjang mjang marked this pull request as ready for review January 28, 2025 21:01
@mjang mjang requested a review from a team as a code owner January 28, 2025 21:01
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, added edit suggestions for some Hugo formatting/file style things.

@mjang mjang requested review from jasonclopper and sylwang January 29, 2025 21:05
@mjang mjang requested review from sylwang and bheftel January 31, 2025 15:47
@mjang mjang changed the title Update cert instructions for NGINX One Console fix: Update cert instructions for NGINX One Console Feb 4, 2025
@mjang mjang force-pushed the update-n1console-diff-certs branch from 1dd4a56 to b7cf0b3 Compare February 5, 2025 20:17
@mjang mjang force-pushed the update-n1console-diff-certs branch from 6e559ad to 62eb725 Compare February 5, 2025 20:48
@mjang mjang merged commit e85ddd9 into main Feb 5, 2025
8 checks passed
@mjang mjang deleted the update-n1console-diff-certs branch February 5, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGINX One Console: based on feedback, clarify process for certs
4 participants