Skip to content

Removed unneeded R33 layouts and migrate to theme #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removed unneeded R33 layouts and migrate to theme #583

wants to merge 4 commits into from

Conversation

lamATnginx
Copy link
Contributor

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/489

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this May 21, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner May 21, 2025 18:01
@lamATnginx lamATnginx added the enhancement New feature or request label May 21, 2025
@lamATnginx lamATnginx changed the title feat: Removed unneeded R33 layouts and migrate to theme Removed unneeded R33 layouts and migrate to theme May 21, 2025
@lamATnginx lamATnginx marked this pull request as draft May 21, 2025 18:02
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim NGINX Instance Manager tooling Back end, repository, Hugo, and all things not related to content labels May 21, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/583/

@github-actions github-actions bot added product/controller NGINX Controller (EOS product) product/mesh NGINX Service Mesh (EOS product) labels May 21, 2025
@lamATnginx lamATnginx marked this pull request as ready for review May 22, 2025 14:17
nginx-jack
nginx-jack reviewed May 23, 2025
View reviewed changes
content/controller/_index.md Outdated
banner:
enabled: true
type: deprecation
start-date: 2024-01-01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say remove the date and type for now, if we're not using for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-jack nginx-jack nginx-jack left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@lamATnginx lamATnginx

Labels
documentation Improvements or additions to documentation enhancement New feature or request product/controller NGINX Controller (EOS product) product/mesh NGINX Service Mesh (EOS product) product/nim NGINX Instance Manager tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @nginx-jack