Skip to content

fix: N1C. Help users look for "out of sync" Instances in a CSG #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 2, 2025
Merged

fix: N1C. Help users look for "out of sync" Instances in a CSG #422

merged 7 commits into from
May 2, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Apr 16, 2025 •
edited
Loading

Proposed changes

Help users understand -- just because you add an Instance to a CSG, they don't automatically sync

Closes #420

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang requested a review from a team as a code owner April 16, 2025 18:26
@mjang mjang self-assigned this Apr 16, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels Apr 16, 2025
@mjang mjang changed the title N1C. Help users look for "out of sync" Instances in a CSG fix: N1C. Help users look for "out of sync" Instances in a CSG Apr 16, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/422/

@mjang mjang requested review from jasonclopper and sylwang April 16, 2025 18:47
ADubhlaoich
ADubhlaoich approved these changes Apr 17, 2025
View reviewed changes
sylwang
sylwang approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@sylwang sylwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for refining this!

mjang and others added 2 commits May 2, 2025 13:58
@mjang @sylwang @ADubhlaoich
Apply suggestions from code review
ae3c0b1 
Co-authored-by: Sylvia Wang <139922338+sylwang@users.noreply.github.com>
Co-authored-by: Alan Dooley <a.dooley@f5.com>
@mjang
Merge branch 'main' into fix-n1c-config-sync-group-instance
206e1aa
@mjang mjang merged commit 97aea9f into main May 2, 2025
9 checks passed
@mjang mjang deleted the fix-n1c-config-sync-group-instance branch May 2, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@sylwang sylwang sylwang approved these changes

@jasonclopper jasonclopper Awaiting requested review from jasonclopper

Assignees

@mjang mjang

Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N1C, when adding instances to a CSG
3 participants
@mjang @ADubhlaoich @sylwang