Skip to content

N1C -- XC-based link update #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025
Merged

N1C -- XC-based link update #379

merged 3 commits into from
Apr 11, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Apr 8, 2025

Proposed changes

Follow-up to #248

  • Left out a link that doesn't work (yet)

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@mjang mjang added bug Something isn't working product/nginx-one NGINX One Console labels Apr 8, 2025
@mjang mjang requested a review from jasonclopper April 8, 2025 16:26
@mjang mjang self-assigned this Apr 8, 2025
@mjang mjang requested a review from a team as a code owner April 8, 2025 16:26
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 8, 2025
Copy link

github-actions bot commented Apr 8, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/379/

Copy link
Contributor

@kamalchaturvedi kamalchaturvedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These existing roles will be updated in production as a part of XC ATOM release. Recommend keeping this MR open until that change has been made.

@mjang mjang marked this pull request as draft April 8, 2025 16:48
@mjang
Copy link
Contributor Author

mjang commented Apr 8, 2025

The roles exist, the link should work soon, probably at https://docs.cloud.f5.com/docs-v2/administration/how-tos/user-mgmt/rbac

@mjang mjang force-pushed the fix-n1c-default-roles branch from 217a794 to faf118d Compare April 11, 2025 16:29
@mjang mjang changed the title N1C -- XC-based. fix role names, link N1C -- XC-based link update Apr 11, 2025
@mjang mjang marked this pull request as ready for review April 11, 2025 16:31
@mjang
Copy link
Contributor Author

mjang commented Apr 11, 2025

These existing roles will be updated in production as a part of XC ATOM release. Recommend keeping this MR open until that change has been made.

@kamalchaturvedi

The broken link is getting attention. I may push this (and set up a second PR once the XC ATOM release is available)

@mjang mjang merged commit dc63cf2 into main Apr 11, 2025
9 checks passed
@mjang mjang deleted the fix-n1c-default-roles branch April 11, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants