Skip to content

Fix printing on all browsers on new theme #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Apr 2, 2025

Proposed changes

Closes: https://github.com/nginxinc/docs-platform/issues/437

Before:
Screenshot 2025-04-02 at 3 33 22 PM

After:
Screenshot 2025-04-02 at 3 32 59 PM

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@lamATnginx lamATnginx added the bug Something isn't working label Apr 2, 2025
@lamATnginx lamATnginx self-assigned this Apr 2, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner April 2, 2025 22:34
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 2, 2025
Copy link

github-actions bot commented Apr 2, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/354/

@lamATnginx lamATnginx force-pushed the fix/print-new-theme branch from 25509b5 to 0723ba9 Compare April 2, 2025 22:45
@lamATnginx
Copy link
Contributor Author

Tested on all browsers (Chrome, Safari, and Firefox). Checks out fine.

@travisamartin
Copy link
Contributor

Tested on Edge Version 134.0.3124.95. Looks nice!

@lamATnginx lamATnginx force-pushed the fix/print-new-theme branch from 0723ba9 to 0415179 Compare April 2, 2025 22:54
@lamATnginx lamATnginx merged commit a0c567a into main Apr 3, 2025
9 checks passed
@lamATnginx lamATnginx deleted the fix/print-new-theme branch April 3, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants