Skip to content

fix: repair N1C API guide #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix: repair N1C API guide #302

merged 1 commit into from
Mar 19, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Mar 19, 2025 •
edited
Loading

Bug

Current version of N1C API guide is essentially blank. https://docs.nginx.com/nginx-one/api/api-reference-guide/

Solution: Revert change in this PR: https://github.com/nginx/documentation/pull/287/files#diff-9656c13ed4404f157b0158296fedd11521f8e35e93e1e27f79728a1155420c0fR1

Testing: Built locally

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang self-assigned this Mar 19, 2025
@mjang mjang marked this pull request as ready for review March 19, 2025 21:56
@mjang mjang requested a review from a team as a code owner March 19, 2025 21:56
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels Mar 19, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/302/

@mjang mjang requested a review from travisamartin March 19, 2025 22:15
@mjang mjang merged commit 7ec3907 into main Mar 19, 2025
9 checks passed
@mjang mjang deleted the fix-n1c-api-ref branch March 19, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisamartin travisamartin travisamartin approved these changes

Assignees

@mjang mjang

Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjang @travisamartin